Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator awx-operator (2.7.0) #3466

Conversation

TheRealHaoLiu
Copy link
Contributor

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description of the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

Hi @TheRealHaoLiu. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from haripate and mporrato October 17, 2023 15:55
@github-actions github-actions bot changed the title operator [N] [CI] awx-operator 2.7.0 operator awx-operator (2.7.0) Oct 17, 2023
@github-actions github-actions bot added authorized-changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2023
@TheRealHaoLiu TheRealHaoLiu force-pushed the publish-awx-operator-2.7.0 branch from 29b1594 to 4e023fe Compare October 17, 2023 15:57
@rooftopcellist
Copy link
Contributor

@TheRealHaoLiu CI is complaining because v4.10 is EOL.

  json:
    detail: Invalid semver in v4.10-v4.13n
    status: 400
    title: Bad Request
    trace_id: '0x657591ff53a1ad10a0471c2f1c232bee'
    type: about:blank
  msg: 'Status code was 400 and not [200]: HTTP Error 400: Bad Request'

Can you change the annotation in bundle/metadata/annotations.yaml to be:

annotations:
  com.redhat.openshift.versions: v4.11

@@ -0,0 +1,14 @@
annotations:
com.redhat.openshift.versions: v4.10-v4.13n # Core bundle annotations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably complaining about the n at the end actually, not the fact that v4.10 is EOL. But none-the-less, can you change this to:

Suggested change
com.redhat.openshift.versions: v4.10-v4.13n # Core bundle annotations.
com.redhat.openshift.versions: v4.11 # Core bundle annotations.

That way it will support v4.11 and up, meaning the awx-operator will automatically be added to v4.14, and v4.15 when it comes out, etc.

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation framework-automation merged commit 3cc256b into redhat-openshift-ecosystem:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants