Skip to content

Commit

Permalink
Merge pull request #164 from redhat-partner-solutions/sanity
Browse files Browse the repository at this point in the history
Renaming Performance to Sanity Performance
  • Loading branch information
dkosteck authored Jul 27, 2023
2 parents 039e62e + 17455e8 commit 8062965
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ jobs:
cd sriov/tests
cp /config/*.yaml ./
if [[ "${mode}" == "full" ]]; then
pytest -v --html=report.html --self-contained-html SR_IOV_* common --ignore-glob="*test_SR_IOV_Performance.py"
pytest -v --html=report.html --self-contained-html SR_IOV_* common --ignore-glob="*test_SR_IOV_Sanity_Performance.py"
echo "generated=true" >> $GITHUB_ENV
elif [[ ${#tests[@]} -ne 0 ]]; then
test_string="pytest -v --html=report.html --self-contained-html --ignore-glob='*test_SR_IOV_Performance.py'"
test_string="pytest -v --html=report.html --self-contained-html --ignore-glob='*test_SR_IOV_Sanity_Performance.py'"
for testname in $(echo "${tests[@]}" | tr ' ' '\n' | sort -u); do
test_string="${test_string} ${testname}"
echo "Testing ${testname}"
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,14 @@ container_volumes: # the volume mapping to use with the container
vlan: # vlan tag used by the vlan tests, default is 10
mtu: # MTU size; if unspecified, the script will derive it
bonding_switch_delay: # Expected bonding switch over/back delay in second, default is 1
# Below required for SR_IOV_Performance
# Below required for SR_IOV_Sanity_Performance
testpmd_img: # testpmd container image
testpmd_port: # testpmd REST port
trafficgen_img: # trafficgen container image
trafficgen_port: # trafficgen REST port
trafficgen_timeout: # trafficgen command timeout (in minutes)
trafficgen_rx_bps_limit: # trafficgen baseline comparison (bps)
log_performance: # boolean, use false to omit performance test details in logs/result files (only pass or fail)
log_performance: # boolean, use false to omit sanity performance test details in logs/result files (only pass or fail)
```

A current version of Python is recommended to run the tests. As of writing the minimum version to avoid warnings would be 3.7. However, the tests have been successfully run up to version 3.11, the latest active release as of writing. The same is true of pip, which should be a current version (23.0 as of writing, but this should be upgraded in the following steps).
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Test Case Name: SR-IOV.Performance
# Test Case Name: SR-IOV.Sanity.Performance

### Objective(s): A RFC2544 performance test to evaluate a system's (relative) performance when running DPDK workloads. This relies on a trafficgen client and containers built from [netgauge](https://github.com/redhat-eets/netgauge)
### Objective(s): A RFC2544 sanity test to evaluate a system's (relative) performance when running DPDK workloads. This relies on a trafficgen client and containers built from [netgauge](https://github.com/redhat-eets/netgauge)

### Test procedure

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

# Use pytest --iteration to adjust the execution_number parameter for desired amount
# of repeated tests
def test_SRIOVPerformance(dut, trafficgen, settings, testdata):
def test_SRIOV_Sanity_Performance(dut, trafficgen, settings, testdata):
"""Test and ensure that VFs provision with MTU functions as intended
Args:
Expand Down

0 comments on commit 8062965

Please sign in to comment.