Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the ability to run e2e tests on different testbeds/NICs #147

Merged
merged 5 commits into from
Mar 20, 2023

Conversation

akiselev1
Copy link
Collaborator

@akiselev1 akiselev1 commented Mar 15, 2023

This PR will address #139

The proposed solution uses a new label (e2e-test-710) to initiate a e2e flow on 710-labelled runner. The original e2e-test label is used to run test on a 810-labeled runner. Manual trigger (workflow_dispatch) allows to choose wither 810 (default) or 710 NIC hw to run. All scenarios were tested in my fork: akiselev1#1

@akiselev1 akiselev1 requested review from dkosteck and jianzzha March 15, 2023 21:47
Copy link
Collaborator

@dkosteck dkosteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just my one comment which is optional/something to consider

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
@akiselev1
Copy link
Collaborator Author

@jianzzha - please take a look

@jianzzha
Copy link
Member

I'm not sure I like the idea of duplicating the same code in different workflow files. If more NIC are added, then more duplication ... Instead, I think we should explore an idea of dynamic setting of runs-on

@akiselev1
Copy link
Collaborator Author

I'm not sure I like the idea of duplicating the same code in different workflow files. If more NIC are added, then more duplication ... Instead, I think we should explore an idea of dynamic setting of runs-on

I don't like it either. I spent a day experimenting with workarounds. As I mentioned in the PR description:

Unfortunately it is not possible to parameterize "runs-on" value for github action flow due to this known issue: actions/runner#480 . Existing workarounds work only for a single label or require 2 files per flow.

Copy link
Member

@jianzzha jianzzha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. The last line of duplicate code is a trade off for less complexity and we can live with that

Copy link
Collaborator

@dkosteck dkosteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we may want to explore the default label if/when we end up with more cards/testbeds, but for now this makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants