-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the ability to run e2e tests on different testbeds/NICs #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just my one comment which is optional/something to consider
@jianzzha - please take a look |
I'm not sure I like the idea of duplicating the same code in different workflow files. If more NIC are added, then more duplication ... Instead, I think we should explore an idea of dynamic setting of runs-on |
I don't like it either. I spent a day experimenting with workarounds. As I mentioned in the PR description: Unfortunately it is not possible to parameterize "runs-on" value for github action flow due to this known issue: actions/runner#480 . Existing workarounds work only for a single label or require 2 files per flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. The last line of duplicate code is a trade off for less complexity and we can live with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we may want to explore the default label if/when we end up with more cards/testbeds, but for now this makes sense
This PR will address #139
The proposed solution uses a new label (e2e-test-710) to initiate a e2e flow on 710-labelled runner. The original e2e-test label is used to run test on a 810-labeled runner. Manual trigger (workflow_dispatch) allows to choose wither 810 (default) or 710 NIC hw to run. All scenarios were tested in my fork: akiselev1#1