-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial working elastic logging for sanity performance tests: #165
Conversation
NOTE: CA Certs failed outside of elastic host, will investigate further soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to add a section in the readme file to explain this optional store capability/dev state.
@jianzzha Thanks for pointing this out, I thought I had added a section to the README but apparently it got lost somewhere along the way. It's now updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The only suggestion would be squash/rebase to clean up commit history.
An initial commit for the pull of results, tags, and timestamp to elastic for further processing/creating dashboards. This commit represents the beginning of being able to use elastic, not a comprehensive implementation. For this reason if other extensions (such as supporting CA Certs, more fields, etc.) are implemented they will follow in subsequent commits.
For information on the elastic and kibana deployment used for testing, see this document