Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial working elastic logging for sanity performance tests: #165

Merged
merged 11 commits into from
Dec 8, 2023

Conversation

dkosteck
Copy link
Collaborator

@dkosteck dkosteck commented Aug 16, 2023

An initial commit for the pull of results, tags, and timestamp to elastic for further processing/creating dashboards. This commit represents the beginning of being able to use elastic, not a comprehensive implementation. For this reason if other extensions (such as supporting CA Certs, more fields, etc.) are implemented they will follow in subsequent commits.

For information on the elastic and kibana deployment used for testing, see this document

@dkosteck dkosteck marked this pull request as ready for review December 6, 2023 21:50
@dkosteck dkosteck requested review from jianzzha and akiselev1 and removed request for jianzzha December 6, 2023 21:50
Copy link
Member

@jianzzha jianzzha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to add a section in the readme file to explain this optional store capability/dev state.

@dkosteck dkosteck requested a review from jianzzha December 8, 2023 20:53
@dkosteck
Copy link
Collaborator Author

dkosteck commented Dec 8, 2023

It might be a good idea to add a section in the readme file to explain this optional store capability/dev state.

@jianzzha Thanks for pointing this out, I thought I had added a section to the README but apparently it got lost somewhere along the way. It's now updated

Copy link
Collaborator

@akiselev1 akiselev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only suggestion would be squash/rebase to clean up commit history.

@dkosteck dkosteck merged commit 011a0af into main Dec 8, 2023
4 checks passed
@dkosteck dkosteck deleted the elastic-perf branch December 8, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants