Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace localhost with dut or trafficgen IPs, add firmware mount, and pull driver for trafficgen reset #169

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Replace localhost with dut or trafficgen IPs, add firmware mount, and pull driver for trafficgen reset #169

merged 5 commits into from
Nov 27, 2023

Conversation

dkosteck
Copy link
Collaborator

@dkosteck dkosteck commented Nov 3, 2023

Waiting on Andy to test before merging

@dkosteck
Copy link
Collaborator Author

dkosteck commented Nov 3, 2023

@akiselev1 This is the updated PR, content is the same just cleaned up

@akiselev1 akiselev1 added e2e-test Ready for an end-to-end test and removed e2e-test Ready for an end-to-end test labels Nov 3, 2023
@akiselev1 akiselev1 added e2e-test Ready for an end-to-end test and removed e2e-test Ready for an end-to-end test labels Nov 9, 2023
@akiselev1 akiselev1 added e2e-test Ready for an end-to-end test and removed e2e-test Ready for an end-to-end test labels Nov 9, 2023
@dkosteck dkosteck changed the title Replace localhost with dut or trafficgen IPs, add firmware mount Replace localhost with dut or trafficgen IPs, add firmware mount, and pull driver for trafficgen reset Nov 14, 2023
@andyho319
Copy link

Hi Daniel,
The commit last week for pulling driver for resetting the trafficgen is working well. This is in addition to the changes made for replacing localhost and adding additional firmware mount

@akiselev1 akiselev1 added the e2e-test Ready for an end-to-end test label Nov 27, 2023
@akiselev1
Copy link
Collaborator

While there was one failed test in e2e run, this failure does not look related to the current set of changes.

@akiselev1 akiselev1 self-requested a review November 27, 2023 18:57
@dkosteck dkosteck marked this pull request as ready for review November 27, 2023 21:51
@dkosteck dkosteck merged commit f49cd3e into main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akiselev1 akiselev1 akiselev1 approved these changes

@jianzzha jianzzha jianzzha approved these changes

Assignees
No one assigned
Labels
e2e-test Ready for an end-to-end test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkosteck @andyho319 @akiselev1 @jianzzha