Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bevo2 configs #186

Closed
wants to merge 5 commits into from
Closed

Conversation

jnunyez
Copy link
Contributor

@jnunyez jnunyez commented Feb 13, 2024

This PR follows the configurations provided in Bevoguide to mimic Day2 configs using ZTP:

  • Adds FEC operator and SRIOVFecClusterConfig
  • SRIOVNetworkNodePolicies

Also adds TGM config in PTP operator.

@jnunyez jnunyez force-pushed the bevo2-Feb13 branch 2 times, most recently from 2b14e46 to e8bed55 Compare February 13, 2024 19:49
Copy link
Member

@novacain1 novacain1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review, some potential problems here.

isRdma: false
nicselector:
pfNames:
- ens5f1#0-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ens5f1#0-1
- ens5f0#0-1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong interface.

isRdma: false
nicselector:
pfNames:
- ens2f0#3-6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ens2f0#3-6
- ens2f0#3-7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to add up to max VFs.

Comment on lines +58 to +61
nodeNetwork:
interfaces:
- name: ens2f0
macAddress: "b4:96:91:a5:04:ac"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nodeNetwork:
interfaces:
- name: ens2f0
macAddress: "b4:96:91:a5:04:ac"
nodeNetwork:
interfaces:
- name: eno12399np0
macAddress: "e4:3d:1a:dd:b8:20"
- name: ens2f0
macAddress: "b4:96:91:a5:04:ac"
- name: ens5f0
macAddress: "50:7c:6f:1f:b3:58"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add broadcom interface like bevo1. also add other connected (with carrier) interfaces.

Copy link
Contributor Author

@jnunyez jnunyez Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more ifaces, and ipaddress confiuration in the broadcom.

Comment on lines 64 to 92
- name: ens2f0
type: ethernet
state: up
ipv4:
enabled: true
address:
- ip: "192.168.38.151"
prefix-length: 26
dhcp: false
ipv6:
enabled: true
address:
- ip: "2600:52:7:300::151"
prefix-length: 64
autoconf: false
dhcp: false
dns-resolver:
config:
server:
- 192.168.38.12
- 2600:52:7:38::12
routes:
config:
- destination: 0.0.0.0/0
next-hop-address: 192.168.38.129
next-hop-interface: ens2f0
- destination: ::/0
next-hop-address: 2600:52:7:300::1
next-hop-interface: ens2f0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: ens2f0
type: ethernet
state: up
ipv4:
enabled: true
address:
- ip: "192.168.38.151"
prefix-length: 26
dhcp: false
ipv6:
enabled: true
address:
- ip: "2600:52:7:300::151"
prefix-length: 64
autoconf: false
dhcp: false
dns-resolver:
config:
server:
- 192.168.38.12
- 2600:52:7:38::12
routes:
config:
- destination: 0.0.0.0/0
next-hop-address: 192.168.38.129
next-hop-interface: ens2f0
- destination: ::/0
next-hop-address: 2600:52:7:300::1
next-hop-interface: ens2f0
- name: eno12399np0
type: ethernet
state: up
ipv4:
enabled: true
address:
- ip: "192.168.38.151"
prefix-length: 26
dhcp: false
ipv6:
enabled: true
address:
- ip: "2600:52:7:300::151"
prefix-length: 64
autoconf: false
dhcp: false
- name: ens2f0
type: ethernet
state: down
- name: ens5f0
type: ethernet
state: down
dns-resolver:
config:
server:
- 192.168.38.12
- 2600:52:7:38::12
routes:
config:
- destination: 0.0.0.0/0
next-hop-address: 192.168.38.129
next-hop-interface: eno12399np0
- destination: ::/0
next-hop-address: 2600:52:7:300::1
next-hop-interface: eno12399np0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch default route to broadcom, unless i'm missing something here? also you need to add other interfaces and set to down so those interfaces don't DHCP constantly (undesired).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not missing anything. Also added all the ports and states.

bmcAddress: "idrac-virtualmedia://192.168.38.204/redfish/v1/Systems/System.Embedded.1"
bmcCredentialsName:
name: "r750-2-bmc-creds-secret"
bootMACAddress: "b4:96:91:a5:04:ac"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bootMACAddress: "b4:96:91:a5:04:ac"
bootMACAddress: "e4:3d:1a:dd:b8:20"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch this to default router interface (eno12399np0).

@jnunyez jnunyez closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants