add nodeName as a new parameter to support MNO usecase #643
nishant-parekhpre_main.yaml
on: pull_request
Run Linter and Vet
3m 54s
Run pkg tests
2m 16s
Lint YAML files
4s
Ensure License Headers
31s
Annotations
5 errors and 7 warnings
|
Run Linter and Vet:
pkg/clients/clientset.go#L102
paramTypeCombine: func(namespace, prefix string, nodeName string) (string, error) could be replaced with func(namespace, prefix, nodeName string) (string, error) (gocritic)
|
|
Run Linter and Vet:
pkg/clients/clientset.go#L128
line is 137 characters (lll)
|
|
Run Linter and Vet:
pkg/cmd/common.go#L46
line is 126 characters (lll)
|
|
Run Linter and Vet:
pkg/collectors/log_follower.go#L57
fieldalignment: struct with 176 pointer bytes could be 128 (govet)
|
|
Run Linter and Vet
issues found
|
|
Lint YAML files
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Ensure License Headers
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Ensure License Headers
Restore cache failed: Dependencies file is not found in /home/runner/work/vse-sync-collection-tools/vse-sync-collection-tools. Supported file pattern: go.sum
|
|
Run pkg tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run pkg tests
Restore cache failed: Dependencies file is not found in /home/runner/work/vse-sync-collection-tools/vse-sync-collection-tools. Supported file pattern: go.sum
|
|
Run Linter and Vet
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4, actions/checkout@v3, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Linter and Vet
Restore cache failed: Dependencies file is not found in /home/runner/work/vse-sync-collection-tools/vse-sync-collection-tools. Supported file pattern: go.sum
|