Netlink #101
Merged
Netlink #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nocturnalastro
force-pushed
the
netlink
branch
from
b44bae3 to
be820e4
Compare
nocturnalastro
force-pushed
the
netlink
branch
from
be820e4 to
86cc8f8
Compare
crwr45
suggested changes
Nov 28, 2023
pkg/clients/exec_command.go
Outdated
| return err | ||
| } | ||
| if len(pods.Items) == 0 || len(pods.Items) > 1 { | ||
| // I don't think k8s allows more than one pod with the same name |
There was a problem hiding this comment.
Pod name has to be unique in a namespace.
This error is wrong if 0 pods are found, and >1 can never be found.
crwr45
approved these changes
Nov 30, 2023
jnunyez
reviewed
Dec 1, 2023
jnunyez
approved these changes
Dec 1, 2023
Co-authored-by: Jose Núñez <[email protected]>
crwr45
approved these changes
Dec 19, 2023
nocturnalastro
merged commit e7353ba
into
redhat-partner-solutions:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.