-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge submodule #79
Merge submodule #79
Conversation
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
postprocess/LICENSE
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the license file should be in the main folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this one here as it's directly referenced in the MANIFEST.in
of the vse_sync_pp
python package in the same directory. I may be able to reference the one in the top level, I'll check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if Github can recognize it if not in the main directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license at the top level is the only one now; I've updated the one in the python package to be a symlink since there has to be one in the directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. I'm trying the test suite with the 3 repos.
One doubt I have is the end destination of this repo (openshift-kni or redhat-partner-solutions) and whether we can preserve or not the open source license.
@jnunyez testdrive is still needed; I'll move bits from there into this repo once this PR is resolved. Very good question about the license; when we know exactly where we are moving to we'll have to check it's compatible. |
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Comments addressed, full round of e2e and container changes to come once testdrive is fully merged in. |
yes, noticed that testdrive is needed. The new PR worked for me.
|
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
95d0a4f
to
2a6c32d
Compare
No description provided.