Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge submodule #79

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Merge submodule #79

merged 7 commits into from
Feb 8, 2024

Conversation

crwr45
Copy link
Contributor

@crwr45 crwr45 commented Jan 31, 2024

No description provided.

Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
.github/workflows/flake8.yaml Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the license file should be in the main folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this one here as it's directly referenced in the MANIFEST.in of the vse_sync_pp python package in the same directory. I may be able to reference the one in the top level, I'll check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if Github can recognize it if not in the main directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license at the top level is the only one now; I've updated the one in the python package to be a symlink since there has to be one in the directory.

Copy link
Collaborator

@jnunyez jnunyez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. I'm trying the test suite with the 3 repos.
One doubt I have is the end destination of this repo (openshift-kni or redhat-partner-solutions) and whether we can preserve or not the open source license.

@crwr45
Copy link
Contributor Author

crwr45 commented Feb 1, 2024

@jnunyez testdrive is still needed; I'll move bits from there into this repo once this PR is resolved. Very good question about the license; when we know exactly where we are moving to we'll have to check it's compatible.

Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
@crwr45 crwr45 requested review from jnunyez and natifridman February 1, 2024 17:01
@crwr45
Copy link
Contributor Author

crwr45 commented Feb 1, 2024

Comments addressed, full round of e2e and container changes to come once testdrive is fully merged in.

.github/workflows/flake8.yaml Outdated Show resolved Hide resolved
@jnunyez
Copy link
Collaborator

jnunyez commented Feb 5, 2024

@jnunyez testdrive is still needed; I'll move bits from there into this repo once this PR is resolved.

yes, noticed that testdrive is needed. The new PR worked for me.

Very good question about the license; when we know exactly where we are moving to we'll have to check it's compatible.
ACK.

Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
Signed-off-by: Charlie Wheeler-Robinson <[email protected]>
@jnunyez jnunyez merged commit 7ad89ea into main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants