Add nodeName as a new parameter to support MNO cluster testing #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node to test in an MNO cluster. * updated e2e.sh to add validations and pass in the nodeName to the verify env and collect scripts. * updated Containerfile to add in nodeName as an argument set to emptyString by default (SNO case) Signed-off-by: Nishant Parekh <[email protected]>
* use of env is preferrable as it only a runtime setting instead of a change to the container build itself
* bugfixes identified from local run
Signed-off-by: Nishant Parekh <[email protected]>
Signed-off-by: Nishant Parekh <[email protected]>
Signed-off-by: Nishant Parekh <[email protected]>
nocturnalastro
merged commit 98ab570
into
redhat-partner-solutions:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added changes to include a new parameter nodeName to pass in the the node to test in an MNO cluster.