Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the logic around last_count working #106

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jhutar
Copy link
Collaborator

@jhutar jhutar commented Oct 11, 2024

Did 2 changes here:

First is the important one where I removed && [[ $last_count -ge 0 ]] as that was blocking changing last_count, because it was initialized to -1. Now it should work as expected.

Second I made sure warning is printed if we fail to obtain current count value.

@jhutar
Copy link
Collaborator Author

jhutar commented Oct 11, 2024

/test mvp

@jhutar jhutar force-pushed the fix6-retry-upload branch from 9d8bbf4 to c169b16 Compare October 11, 2024 11:22
@jhutar
Copy link
Collaborator Author

jhutar commented Oct 11, 2024

/test mvp

1 similar comment
@jhutar
Copy link
Collaborator Author

jhutar commented Oct 14, 2024

/test mvp

Copy link

openshift-ci bot commented Oct 14, 2024

@jhutar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/mvp c169b16 link true /test mvp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ci-scripts/rhdh-setup/create_resource.sh Outdated Show resolved Hide resolved
ci-scripts/rhdh-setup/create_resource.sh Outdated Show resolved Hide resolved
@jhutar jhutar force-pushed the fix6-retry-upload branch 2 times, most recently from 279f8e4 to 8dba97c Compare October 17, 2024 07:35
Did 2 changes here:

First is the important one where I removed `&& [[ $last_count -ge 0 ]]`
as that was blocking changing last_count, because it was initialized to
-1. Now it should work as expected.

Second I made sure warning is printed if we fail to obtain current count
value.
@pmacik pmacik force-pushed the fix6-retry-upload branch from 8dba97c to da9fddd Compare October 23, 2024 10:13
Copy link
Collaborator

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thx @jhutar

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2024
Copy link

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhutar, pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cbd94db into main Oct 23, 2024
3 checks passed
pmacik pushed a commit that referenced this pull request Oct 24, 2024
Did 2 changes here:

First is the important one where I removed `&& [[ $last_count -ge 0 ]]`
as that was blocking changing last_count, because it was initialized to
-1. Now it should work as expected.

Second I made sure warning is printed if we fail to obtain current count
value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants