-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make the logic around last_count
working
#106
Conversation
/test mvp |
9d8bbf4
to
c169b16
Compare
/test mvp |
1 similar comment
/test mvp |
@jhutar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
279f8e4
to
8dba97c
Compare
Did 2 changes here: First is the important one where I removed `&& [[ $last_count -ge 0 ]]` as that was blocking changing last_count, because it was initialized to -1. Now it should work as expected. Second I made sure warning is printed if we fail to obtain current count value.
8dba97c
to
da9fddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thx @jhutar
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhutar, pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Did 2 changes here: First is the important one where I removed `&& [[ $last_count -ge 0 ]]` as that was blocking changing last_count, because it was initialized to -1. Now it should work as expected. Second I made sure warning is printed if we fail to obtain current count value.
Did 2 changes here:
First is the important one where I removed
&& [[ $last_count -ge 0 ]]
as that was blocking changing last_count, because it was initialized to -1. Now it should work as expected.Second I made sure warning is printed if we fail to obtain current count value.