Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable keycloak plugin #24

Conversation

yogananth-subramanian
Copy link
Collaborator

Enable Keycloak dynamic plugin.

@openshift-ci openshift-ci bot requested review from jhutar and pmacik December 21, 2023 13:19
@pmacik
Copy link
Collaborator

pmacik commented Dec 22, 2023

/test ?

Copy link

openshift-ci bot commented Dec 22, 2023

@pmacik: The following commands are available to trigger required jobs:

  • /test images
  • /test list-catalog
  • /test list-catalog-empty
  • /test list-catalog-scalability
  • /test search-catalog
  • /test search-catalog-scalability

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-redhat-performance-backstage-performance-main-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmacik
Copy link
Collaborator

pmacik commented Dec 22, 2023

/test list-catalog
/test list-catalog-scalability

Copy link
Collaborator

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yogananth-subramanian PTAL yogananth-subramanian#1

Following the docs about the keycloak dynamic plugin, I found that you must set some env variables.

With the above fix the users/groups are integrated with keycloak

@yogananth-subramanian
Copy link
Collaborator Author

@yogananth-subramanian PTAL yogananth-subramanian#1

Following the docs about the keycloak dynamic plugin, I found that you must set some env variables.

With the above fix the users/groups are integrated with keycloak

Hello @pmacik, since those variable are already set in the config, I was able to sync up keycloak and backstage without setting those environment variables again in plugin part of the config.
But since it is recommended in the doc, as you have pointed out, will test and revise this patch based on the recommendation.

Enable Keycloak dynamic plugin.
…ugin work, fix minor bugs and sanitize code (#1)

* Enable keycloak plugin

Enable Keycloak dynamic plugin.

* fix(keycloak-plugin): set mandatory env variables to make keycloak plugin work, fix minor bugs and sanitize code

Signed-off-by: Pavel Macík <[email protected]>

---------

Signed-off-by: Pavel Macík <[email protected]>
Co-authored-by: yogananth subramanian <[email protected]>
@pmacik
Copy link
Collaborator

pmacik commented Jan 3, 2024

/test ?

Copy link

openshift-ci bot commented Jan 3, 2024

@pmacik: The following commands are available to trigger required jobs:

  • /test images
  • /test list-catalog
  • /test list-catalog-empty
  • /test list-catalog-scalability
  • /test search-catalog
  • /test search-catalog-scalability

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-redhat-performance-backstage-performance-main-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmacik
Copy link
Collaborator

pmacik commented Jan 3, 2024

/test list-catalog
/test list-catalog-scalability

Copy link
Collaborator

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold for tests to succeed

Copy link

openshift-ci bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik, yogananth-subramanian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pmacik,yogananth-subramanian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik
Copy link
Collaborator

pmacik commented Jan 3, 2024

Scalability jobs currently broken until openshift/release#47203 is merged

@pmacik
Copy link
Collaborator

pmacik commented Jan 4, 2024

/retest

@pmacik
Copy link
Collaborator

pmacik commented Jan 4, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit fe848fe into redhat-performance:main Jan 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants