-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keycloak user authentication #33
keycloak user authentication #33
Conversation
b0c06ad
to
6bc610a
Compare
/hold |
c433694
to
f40588e
Compare
Hello @pmacik The hard-coded password references have been removed, and the keycloak user password is now stored in a secret for reference. |
@yogananth-subramanian Your changes do enable the keycloak authentication all the time. IMHO, it would be useful to have a means to disabe the keycloak authentication feature. So that we can still have the original behavior (un-authenticated) available. For example, via means of an environment variable such as If it is set to This would also enable us to measure the authentication's own overhead. Thanks! |
key: CLIENT_SECRET | ||
name: keycloak-client-secret-backstage | ||
- name: OAUTH2_PROXY_COOKIE_SECRET | ||
value: '${COOKIE_SECRET}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yogananth-subramanian A best-practice advice: As it is a secret, it should not be put into the container spec as plain text. You should put it into a Secret
resource and use the same .valueFrom.secretKeyRef
approach as shown in case of CLIENT_SECRET
variable above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmacik for the review, agree with your comment. Have fixed it in the latest commit, have moved it to a secret.
This patch enables user authentication using keycloak in backstage setup and locust mvp test. This is done by setting environment variable AUTH_PROVIDER to keycloak. export AUTH_PROVIDER=keycloak
f40588e
to
458c5db
Compare
Hello @pmacik , thanks for your review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhutar, yogananth-subramanian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
59f40e7
into
redhat-performance:main
This patch enabled user authentication using keycloak.