Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHIDP-2121): Fix metrics collector to support both OLM and Helm #54

Merged

Conversation

pmacik
Copy link
Collaborator

@pmacik pmacik commented Jun 18, 2024

No description provided.

Copy link

openshift-ci bot commented Jun 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pmacik
Copy link
Collaborator Author

pmacik commented Jun 18, 2024

/test mvp-olm
/test mvp-helm

@pmacik pmacik changed the title chore(RHDIP-2121): [DO NOT MERGE] Run MVP tests to compare OLM and RHIDP chore(RHIDP-2121): [DO NOT MERGE] Run MVP tests to compare OLM and Helm Jun 18, 2024
@pmacik pmacik changed the title chore(RHIDP-2121): [DO NOT MERGE] Run MVP tests to compare OLM and Helm fix(RHIDP-2121): Fix metrics collector to support both OLM and Helm Jun 19, 2024
@pmacik pmacik force-pushed the chore/olm-vs-helm branch 4 times, most recently from 6e28cf5 to dcea788 Compare June 19, 2024 10:17
@pmacik
Copy link
Collaborator Author

pmacik commented Jun 19, 2024

/hold

@pmacik pmacik marked this pull request as ready for review June 19, 2024 10:17
@pmacik
Copy link
Collaborator Author

pmacik commented Jun 19, 2024

/test mvp-olm
/test mvp-helm

@pmacik
Copy link
Collaborator Author

pmacik commented Jun 19, 2024

Verified by :

@pmacik pmacik force-pushed the chore/olm-vs-helm branch from dcea788 to 3c89098 Compare June 19, 2024 12:33
@pmacik
Copy link
Collaborator Author

pmacik commented Jun 19, 2024

/unhold

Copy link
Collaborator

@jhutar jhutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhutar, pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 27c9fa8 into redhat-performance:main Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants