fix(RHIDP-2675): fix backend secret for ver 1.1 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yogananth-subramanian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yogananth-subramanian
force-pushed
the
RHIDP-2675
branch
from
fbe59d8 to
9ea921c
Compare
yogananth-subramanian
force-pushed
the
RHIDP-2675
branch
from
9ea921c to
128ccf1
Compare
Patch adds backward compatibility to use RHDH 1.1 helm repo, by setting backend secret name in the helm charts as a variable. Tested with below config: For RHDH 1.1 RHDH_HELM_REPO="https://raw.githubusercontent.com/rhdh-bot/openshift-helm-charts/developer-hub-1.1.0/installation/" RHDH_HELM_CHART="developer-hub" For RHDH 1.2 RHDH_HELM_REPO=https://raw.githubusercontent.com/rhdh-bot/openshift-helm-charts/redhat-developer-hub-1.2-103-CI/installation/ RHDH_HELM_CHART=redhat-developer-hub
yogananth-subramanian
force-pushed
the
RHIDP-2675
branch
from
128ccf1 to
b07ba6c
Compare
yogananth-subramanian
merged commit 0e08c95
into
redhat-performance:main
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch adds backward compatibility to use RHDH 1.1 helm repo, by setting backend secret name in the helm charts as a variable. Tested with below config:
For RHDH 1.1
RHDH_HELM_REPO="https://raw.githubusercontent.com/rhdh-bot/openshift-helm-charts/developer-hub-1.1.0/installation/" RHDH_HELM_CHART="developer-hub"
For RHDH 1.2
RHDH_HELM_REPO=https://raw.githubusercontent.com/rhdh-bot/openshift-helm-charts/redhat-developer-hub-1.2-103-CI/installation/ RHDH_HELM_CHART=redhat-developer-hub