feat(RHIDP-872): Enable RHDH nodejs metrics

[yogananth-subramanian]

Enable collecting RHDH nodejs prometheus metrics.
The environement variable RHDH_METRIC is set to true to enable collecting the metrics.

[jhutar]

Here it might be easier to read just a multiple calls to that macro instead of a loop with these ifs. And maybe learn rhdh_nodejs_lst to accept value_list instead of just value:

rhdh_nodejs_lst('catalog_processors_duration_seconds_sum', 'result', ['ok', 'failed'])
rhdh_nodejs_lst('catalog_processors_duration_seconds_count', 'result', ['ok', 'failed'])
rhdh_nodejs_lst('catalog_processing_duration_seconds_sum', 'result', ['unchanged'])
rhdh_nodejs_lst('catalog_processing_duration_seconds_count', 'result', ['unchanged'])
rhdh_nodejs_lst('nodejs_gc_duration_seconds_sum', 'kind', ['minor', 'major', 'incremental'])
rhdh_nodejs_lst('nodejs_gc_duration_seconds_count', 'kind', ['minor', 'major', 'incremental'])
rhdh_nodejs_lst('catalog_entities_count', 'kind', ['location', 'user', 'group'])

[jhutar]

Thinking about it more, are these metrics important for us? Or do we want to just collect averages?

catalog_processors_duration_seconds_sum{result="ok"} / catalog_processors_duration_seconds_count{result="ok"}

And maybe just number of failed ones?

rate(catalog_processors_duration_seconds_count{result="failed"}[5m])

I mean - instead of collecting all/lots of the individual metrics that are there, just collect these we actually care about?

[yogananth-subramanian]

Hello @jhutar , thanks for the comments, in the latest commit I have rewritten metric collection in more readable way, as you have suggested and also added metrics for gathering rates and averages instead of just raw data.

[jhutar]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhutar, yogananth-subramanian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhutar,yogananth-subramanian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhutar]

Thank you!