Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the tag_azure operations to cro #666

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Added the tag_azure operations to cro #666

merged 1 commit into from
Sep 6, 2023

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Sep 4, 2023

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Part 1: Tagged the Azure resources with the TicketId tag.
Flow :

  1. List all the resource_groups
  2. Get the resources in the resource_group
  3. Check the ticket_id is present in any of the resources/ resource_group
  4. if found ticket_id tag, tag all resources under the resource_group.

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added documentation Improvements or additions to documentation enhancement New feature or request ok-to-test PR ok to test labels Sep 4, 2023
@athiruma athiruma requested a review from ebattat September 4, 2023 12:35
@athiruma athiruma self-assigned this Sep 4, 2023
ebattat
ebattat reviewed Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma, Do you plan to add the auto tagging for Azure resource ?

cloud_governance/cloud_resource_orchestration/monitor/cloud_monitor.py Outdated Show resolved Hide resolved
cloud_governance/cloud_resource_orchestration/monitor/cloud_monitor.py Outdated Show resolved Hide resolved
cloud_governance/cloud_resource_orchestration/monitor/cloud_monitor.py Show resolved Hide resolved
cloud_governance/common/clouds/azure/compute/common_operations.py Show resolved Hide resolved
cloud_governance/common/clouds/azure/compute/resource_group_operations.py Outdated Show resolved Hide resolved
cloud_governance/common/clouds/azure/compute/resource_group_operations.py Outdated Show resolved Hide resolved
cloud_governance/common/clouds/azure/subscriptions/azure_operations.py Outdated Show resolved Hide resolved
ebattat
ebattat approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit f154de7 into redhat-performance:main Sep 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat approved these changes

Assignees

@athiruma athiruma

Labels
documentation Improvements or additions to documentation enhancement New feature or request ok-to-test PR ok to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat