Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the tenant folder #669

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Sep 6, 2023

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Adding the tenant folder template to add new accounts.

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added documentation Improvements or additions to documentation ok-to-test PR ok to test labels Sep 6, 2023
@athiruma athiruma requested a review from ebattat September 6, 2023 15:00
@athiruma athiruma self-assigned this Sep 6, 2023
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the tenant should be in the following hierarchy:

jenkins/aws/tenant/default/ => current existing folder
jenkins/aws/tenant/Haim
jenkins/aws/tenant/Mikhail

@athiruma
Copy link
Collaborator Author

athiruma commented Sep 7, 2023

I think that the tenant should be in the following hierarchy:

jenkins/aws/tenant/default/ => current existing folder jenkins/aws/tenant/Haim jenkins/aws/tenant/Mikhail

We will maintain our Jenkins file in a separate directory.
Haim/ Mikhail needs to create their own directory in the tenant's folder and can push those changes here.

@ebattat
Copy link
Collaborator

ebattat commented Sep 8, 2023

@athiruma, current configuration should be under tenant -> default
any other tenant configuration should be on different folder name

@athiruma
Copy link
Collaborator Author

@athiruma, current configuration should be under tenant -> default any other tenant configuration should be on different folder name

Done.
I am not adding our Jenkins file to this tenant.

@ebattat ebattat merged commit db46abb into redhat-performance:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants