Added the tenants: ecoeng_01, ecoeng_02, ecoeng_03 #672

athiruma · 2023-09-18T12:52:49Z

Type of change

Note: Fill x in []

bug
enhancement
documentation
dependencies

Description

Adding the managed tenants.

For security reasons, all pull requests need to be approved first before running any automated CI

jenkins/tenant/aws/ecoeng/PolicyJenkinsfileDaily

ebattat

@athiruma Please fix the folder name from mikhail_02 to ecoeng_02

athiruma · 2023-09-27T10:39:43Z

@athiruma Please fix the folder name from mikhail_02 to ecoeng_02

done

ebattat · 2023-10-04T05:53:37Z

@athiruma, did Michail review it ?

athiruma · 2023-10-04T07:14:26Z

@athiruma, did Michail review it ?

no. Yet to review.

athiruma · 2023-10-04T07:16:18Z

@redmikhail ptal 👋

redmikhail · 2023-12-07T15:06:00Z

@athiruma LGTM

ebattat · 2023-12-14T15:15:33Z

jenkins/tenant/aws/ecoeng_3/TaggingJenkinsfileHourly

+                 sh '''if [[ "$(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null)" != "" ]]; then podman rmi -f $(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null); fi'''
+            }
+        }
+        stage('Run Tagging Cluster & Non-Cluster') {


Are you sure it tagging stage ?

It is an tagging job.

ebattat · 2023-12-14T15:16:27Z

jenkins/tenant/aws/ecoeng_3/PolicyJenkinsfileDaily

+                 sh '''if [[ "$(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null)" != "" ]]; then podman rmi -f $(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null); fi'''
+            }
+        }
+        stage('Run Policies the Cost Policies') {


Run Cost Policies - fix it in all places

ebattat · 2023-12-14T15:16:51Z

jenkins/tenant/aws/ecoeng_3/PolicyJenkinsfileDaily

+                }
+            }
+        }
+        stage('Run Policies the Daily polices') {


Run Daily Policies - fix it in all places

ebattat · 2023-12-19T15:21:52Z

jenkins/tenant/aws/ecoeng_3/PolicyJenkinsfileDaily

@@ -0,0 +1,80 @@
+account = ['industry-partners', 'special-projects', 'edgeinfra', 'specialprojects-qe', 'ecoeng-sap', 'sysdeseng', 'verticals-ui']


ecoeng_03 instead of ecoeng_3

ebattat · 2023-12-19T15:22:44Z

jenkins/tenant/aws/ecoeng_01/PolicyJenkinsfileDaily

+                                        string(credentialsId: "${account[i]}-aws-secret-key-id", variable: 'secret_key'),
+                                        string(credentialsId: "${account[i]}-s3-bucket", variable: 's3_bucket')]) {
+                        env.account_name = "${account[i]}"
+                        sh 'python3 jenkins/poc/haim/common/run_cost_policies.py'


Is this path properly ?, if not pls fix it for all 3 groups

ebattat · 2023-12-19T15:27:31Z

jenkins/tenant/aws/ecoeng_01/PolicyJenkinsfileDaily

+                                        string(credentialsId: "${account[i]}-aws-secret-key-id", variable: 'secret_key'),
+                                        string(credentialsId: "${account[i]}-s3-bucket", variable: 's3_bucket')]) {
+                        env.account_name = "${account[i]}"
+                        sh 'python3 jenkins/poc/haim/common/run_policies.py'


Is this path properly ?

I think that we should pass argument:
Configure in jenkinsfile:
policies_in_action = ['ebs_unattached', 'ip_unattached', 'zombie_snapshots', 'unused_nat_gateway', 's3_inactive', 'empty_roles']

python3 jenkins/poc/haim/common/run_policies.py "$policies_in_action"

Please fix it in all 3 groups: ecoeng01/02/03

There is no need to pass to the file, we can access it by os.environ variable.

ebattat

You should move all action policies list in jenkinsfile and pass it as argument ?

ebattat · 2023-12-20T12:25:50Z

jenkins/tenant/aws/common/run_policies.py

+
+exclude_policies = ['cost_explorer', 'optimize_resources_report', 'monthly_report', 'cost_over_usage',
+                    'skipped_resources', 'cost_explorer_payer_billings', 'cost_billing_reports', 'spot_savings_analysis']
+available_policies = get_custodian_policies(exclude_policies=exclude_policies)


get_custodian_policies ?

Sry, it is get policies. Get all policies with excluding the cost policies.

athiruma · 2023-12-20T12:33:48Z

jenkins/tenant/aws/ecoeng_02/PolicyJenkinsfileDaily

+        contact2 = "[email protected]"
+        // By default, all policies are running in dry_run="yes" mode and the whole list can be found in run_policies.py
+        // POLICIES_IN_ACTION: Policies that run in the dry_run="no" mode
+        POLICIES_IN_ACTION = ["ebs_unattached", "ip_unattached", "zombie_snapshots", "unused_nat_gateway", "s3_inactive", "empty_roles"]


This is the policy list in action

ebattat · 2023-12-20T15:30:07Z

jenkins/tenant/aws/ecoeng_02/PolicyJenkinsfileDaily

+                                        string(credentialsId: "${account[i]}-aws-secret-key-id", variable: 'secret_key'),
+                                        string(credentialsId: "${account[i]}-s3-bucket", variable: 's3_bucket')]) {
+                        env.account_name = "${account[i]}"
+                        sh 'python3 jenkins/tenant/aws/common/run_policies.py'


You should pass the policies here
Can we use the following variable:
available_policies = list of all our policies [Should be env variable] => should configured in cg variables.
active_policies = list of active policies per Jenkinsfile and it should pass from Jenkinsfile as following
python3 jenkins/tenant/aws/common/run_policies.py "active_policies"

if that works, pls fix it for all the groups

This is the way of passing by arguments, it is always better to expose it environment and consume it in the file.
I don't agree with the available policies here. The policies should be changed. Thats the reason I added it inside the python dynamically. Coming to active_polices, I added the ENV variable POLICIES_IN_ACTION, describes which are in action.

ebattat

/LGTM
Lets wait to Haim to approve it also

redmikhail · 2024-01-09T14:43:56Z

LGTM

jenkins/tenant/aws/ecoeng_01/PolicyJenkinsfileDaily

jenkins/tenant/aws/ecoeng_01/TaggingJenkinsfileHourly

athiruma added documentation Improvements or additions to documentation ok-to-test PR ok to test labels Sep 18, 2023

athiruma requested a review from ebattat September 18, 2023 12:52

athiruma self-assigned this Sep 18, 2023

ebattat changed the title ~~Added the tenanats: ecoeng, mikhail~~ Added the tenants: ecoeng, mikhail Sep 20, 2023

ebattat approved these changes Sep 20, 2023 •

edited

Loading

View reviewed changes

ebattat reviewed Sep 26, 2023

View reviewed changes

jenkins/tenant/aws/ecoeng/PolicyJenkinsfileDaily Outdated Show resolved Hide resolved

athiruma force-pushed the add_tenants branch from e11db2a to 4ccfd94 Compare September 26, 2023 13:39

athiruma changed the title ~~Added the tenants: ecoeng, mikhail~~ Added the tenants: ecoeng_01, ecoeng_02 Sep 26, 2023

ebattat reviewed Sep 27, 2023

View reviewed changes

athiruma force-pushed the add_tenants branch from 4ccfd94 to 0992429 Compare September 27, 2023 10:27

athiruma force-pushed the add_tenants branch from ed7284a to 833a0ff Compare November 16, 2023 08:03

athiruma force-pushed the add_tenants branch 2 times, most recently from bd18f65 to 07d0d72 Compare December 5, 2023 10:09

athiruma force-pushed the add_tenants branch from 07d0d72 to 169aaf4 Compare December 14, 2023 10:33

ebattat changed the title ~~Added the tenants: ecoeng_01, ecoeng_02~~ Added the tenants: ecoeng_01, ecoeng_02, ecoeng_03 Dec 14, 2023

ebattat reviewed Dec 14, 2023

View reviewed changes

ebattat reviewed Dec 19, 2023

View reviewed changes

athiruma force-pushed the add_tenants branch from 169aaf4 to a95c3cd Compare December 20, 2023 12:14

ebattat reviewed Dec 20, 2023

View reviewed changes

athiruma force-pushed the add_tenants branch from a95c3cd to 22ad1d1 Compare December 20, 2023 12:32

athiruma commented Dec 20, 2023

View reviewed changes

ebattat reviewed Dec 20, 2023

View reviewed changes

athiruma force-pushed the add_tenants branch from 22ad1d1 to a6f0d2f Compare December 21, 2023 08:15

ebattat approved these changes Dec 21, 2023

View reviewed changes

athiruma added 2 commits January 2, 2024 11:58

Added the tenanats: ecoeng, mikhail

f5ec374

Added the new acconuts

f7acd7e

athiruma force-pushed the add_tenants branch 2 times, most recently from a07a68e to 2f26fc9 Compare January 3, 2024 12:21

ebattat reviewed Jan 9, 2024

View reviewed changes

jenkins/tenant/aws/ecoeng_01/PolicyJenkinsfileDaily Outdated Show resolved Hide resolved

ebattat reviewed Jan 9, 2024

View reviewed changes

jenkins/tenant/aws/ecoeng_01/TaggingJenkinsfileHourly Outdated Show resolved Hide resolved

Added the policy to the Jenkinsfile

eceaa97

athiruma force-pushed the add_tenants branch from 2f26fc9 to eceaa97 Compare January 10, 2024 06:01

ebattat approved these changes Jan 10, 2024

View reviewed changes

ebattat merged commit 87b2f06 into redhat-performance:main Jan 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the tenants: ecoeng_01, ecoeng_02, ecoeng_03 #672

Added the tenants: ecoeng_01, ecoeng_02, ecoeng_03 #672

athiruma commented Sep 18, 2023

ebattat left a comment •

edited

Loading

athiruma commented Sep 27, 2023

ebattat commented Oct 4, 2023

athiruma commented Oct 4, 2023

athiruma commented Oct 4, 2023

redmikhail commented Dec 7, 2023

ebattat Dec 14, 2023

athiruma Dec 20, 2023

ebattat Dec 14, 2023 •

edited

Loading

ebattat Dec 14, 2023 •

edited

Loading

ebattat Dec 19, 2023

ebattat Dec 19, 2023

ebattat Dec 19, 2023

athiruma Dec 20, 2023

ebattat left a comment

ebattat Dec 20, 2023

athiruma Dec 20, 2023

athiruma Dec 20, 2023

ebattat Dec 20, 2023 •

edited

Loading

athiruma Dec 21, 2023

ebattat left a comment

redmikhail commented Jan 9, 2024

		@@ -0,0 +1,80 @@
		account = ['industry-partners', 'special-projects', 'edgeinfra', 'specialprojects-qe', 'ecoeng-sap', 'sysdeseng', 'verticals-ui']

Added the tenants: ecoeng_01, ecoeng_02, ecoeng_03 #672

Added the tenants: ecoeng_01, ecoeng_02, ecoeng_03 #672

Conversation

athiruma commented Sep 18, 2023

Type of change

Description

For security reasons, all pull requests need to be approved first before running any automated CI

ebattat left a comment • edited Loading

Choose a reason for hiding this comment

athiruma commented Sep 27, 2023

ebattat commented Oct 4, 2023

athiruma commented Oct 4, 2023

athiruma commented Oct 4, 2023

redmikhail commented Dec 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ebattat Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

ebattat Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ebattat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ebattat Dec 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ebattat left a comment

Choose a reason for hiding this comment

redmikhail commented Jan 9, 2024

ebattat left a comment •

edited

Loading

ebattat Dec 14, 2023 •

edited

Loading

ebattat Dec 14, 2023 •

edited

Loading

ebattat Dec 20, 2023 •

edited

Loading