Added the cluster_cost to the cro #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
added
documentation
|
nice, thanks for the work @athiruma 👍🏻 |
ebattat
reviewed
Sep 22, 2023
| @@ -21,6 +21,11 @@ | |||
| CRO_PORTAL = os.environ['CRO_PORTAL'] | |||
| CRO_COST_OVER_USAGE = os.environ['CRO_COST_OVER_USAGE'] | |||
| CRO_ES_INDEX = os.environ['CRO_ES_INDEX'] | |||
| AWS_ACCESS_KEY_ID_ATHIRUMA_BOT = os.environ['AWS_ACCESS_KEY_ID_ATHIRUMA_BOT'] | |||
| AWS_SECRET_ACCESS_KEY_ATHIRUMA_BOT = os.environ['AWS_SECRET_ACCESS_KEY_ATHIRUMA_BOT'] | |||
There was a problem hiding this comment.
AWS_ACCESS_KEY_ID_ATHIRUMA_BOT, AWS_ACCESS_KEY_ID_ATHIRUMA_BOT
Are those the same as:
ATHENA_ACCOUNT_ACCESS_KEY, ATHENA_ACCOUNT_SECRET_KEY
There was a problem hiding this comment.
Yes, I am using my creds to querying the Athena database.
There was a problem hiding this comment.
these are my personal creds, So I named them as my creds.
We need to pass the Athena creds. So I am asking for the Athena creds.
have them already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Adding the cluster details and the cluster_cost.
For security reasons, all pull requests need to be approved first before running any automated CI