Fixed minor changes #674
Merged
Fixed minor changes #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
force-pushed
the
fix_cro_sub_task_error
branch
from
5897009 to
b27d1da
Compare
ebattat
reviewed
Sep 26, 2023
| @@ -77,7 +76,7 @@ def __monitor_instances(self): | |||
| for ticket_id, cluster_data in cluster_tickets.items(): | |||
| for cluster_id, cluster_values in cluster_data.items(): | |||
| cluster_values['cluster_name'] = cluster_id.split('/')[-1] | |||
| monitored_ticket_ids[ticket_id].append(cluster_values) | |||
| monitored_ticket_ids.setdefault(ticket_id, []).append(cluster_values) | |||
There was a problem hiding this comment.
Is that ok, default is empty list ?
Why not to set it before the loop ?
There was a problem hiding this comment.
yes, we have two types of resources cluster and non-cluster. This loop is for cluster data. If we didn't find the non-cluster data default is empty. So we need to set the default as an empty list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Removed some bugs in the code.
For security reasons, all pull requests need to be approved first before running any automated CI