Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the cost in the es #677

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Updated the sub_ticket cost to the es index.

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma requested a review from ebattat September 27, 2023 15:33
@athiruma athiruma self-assigned this Sep 27, 2023
@@ -101,6 +102,9 @@ def extend_tickets_budget(self, ticket_id: str, region_name: str):
if string_equal_ignore_case(self.__cloud_name, 'AWS'):
self.update_budget_tag_to_resources(region_name=region_name, ticket_id=ticket_id,
updated_budget=total_budget_to_extend)
update_data = {'actual_cost': int(current_budget) + int(total_budget_to_extend)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update_data = {'actual_cost': int(current_budget) + int(total_budget_to_extend)}

is it ok ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's fine.
Its now updated with estimated_cost

@athiruma athiruma force-pushed the cro_aws_update_cost branch 3 times, most recently from 54dcf7f to b4d3849 Compare September 27, 2023 16:14
@athiruma athiruma added bug Something isn't working ok-to-test PR ok to test labels Sep 27, 2023
@ebattat ebattat merged commit bd459cc into redhat-performance:main Sep 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants