Enable the email alert #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
added
bug
ebattat
reviewed
Oct 5, 2023
| ldap_data = self._ldap.get_user_details(user_name=to) | ||
| cc = [self._account_admin, f'{ldap_data.get("managerId")}@redhat.com'] | ||
| if email_id: |
There was a problem hiding this comment.
What the purpose of this email adding ?
There was a problem hiding this comment.
if user name is not in LDAP, we need to check Email tag.
| @@ -27,7 +27,7 @@ | |||
| os.system(f"echo Polices list: {policies_not_in_action}") | |||
| for region in regions: | |||
| for policy in policies_not_in_action: | |||
| os.system(f"""podman run --rm --name cloud-governance-poc-haim --net="host" -e MANAGER_EMAIL_ALERT="False" -e EMAIL_ALERT="False" -e account="{account_name}" -e policy="{policy}" -e AWS_ACCESS_KEY_ID="{access_key}" -e AWS_SECRET_ACCESS_KEY="{secret_key}" -e AWS_DEFAULT_REGION="{region}" -e dry_run="yes" -e LDAP_HOST_NAME="{LDAP_HOST_NAME}" -e es_host="{ES_HOST}" -e es_port="{ES_PORT}" -e policy_output="s3://{s3_bucket}/{LOGS}/{region}" -e log_level="INFO" quay.io/ebattat/cloud-governance:latest""") | |||
| os.system(f"""podman run --rm --name cloud-governance-poc-haim --net="host" -e MANAGER_EMAIL_ALERT="True" -e EMAIL_ALERT="True" -e account="{account_name}" -e policy="{policy}" -e AWS_ACCESS_KEY_ID="{access_key}" -e AWS_SECRET_ACCESS_KEY="{secret_key}" -e AWS_DEFAULT_REGION="{region}" -e dry_run="yes" -e LDAP_HOST_NAME="{LDAP_HOST_NAME}" -e es_host="{ES_HOST}" -e es_port="{ES_PORT}" -e policy_output="s3://{s3_bucket}/{LOGS}/{region}" -e log_level="INFO" quay.io/ebattat/cloud-governance:latest""") | |||
There was a problem hiding this comment.
It should be only for Haim's account, Why do you enable it for all the accounts ?
There was a problem hiding this comment.
It is commonfolder, so it should be enabled by default
athiruma
force-pushed
the
enable_email_alert
branch
2 times, most recently
from
3700adf to
a18f1e1
Compare
athiruma
force-pushed
the
enable_email_alert
branch
from
a18f1e1 to
0788eb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Enabled the email alert.
For security reasons, all pull requests need to be approved first before running any automated CI