Added the instance_type to report #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
added
documentation
ebattat
reviewed
Oct 9, 2023
athiruma
force-pushed
the
cloudsensei_add_type
branch
from
ad0223e to
d50e724
Compare
ebattat
reviewed
Oct 10, 2023
| @@ -77,7 +77,8 @@ def get_resources(self): | |||
| long_running_instances_by_user.setdefault(user.lower(), {}).setdefault(region_name, []).append( | |||
| {'InstanceId': resource.get('InstanceId'), | |||
| 'Name': name, 'LaunchDate': str(launch_time), | |||
| 'RunningDays': f"{days} days", 'State': resource.get('State', {}).get('Name')}) | |||
| 'RunningDays': f"{days} days", 'State': resource.get('State', {}).get('Name'), | |||
| 'InstanceType': resource.get('InstanceType')}) | |||
There was a problem hiding this comment.
can you change the order also here 'InstanceType' before 'RunningDays' ?
There was a problem hiding this comment.
No need, It is the data storing/ returning variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Added the instance_type to the cloudsensei report
For security reasons, all pull requests need to be approved first before running any automated CI