Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the missed policy in tagging #688

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Added the missed policy in tagging #688

merged 1 commit into from
Oct 19, 2023

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Added the missed policy in tagging

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added bug Something isn't working ok-to-test PR ok to test labels Oct 19, 2023
@athiruma athiruma requested a review from ebattat October 19, 2023 14:19
@athiruma athiruma self-assigned this Oct 19, 2023
ebattat
ebattat reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma, What the purpose to add ebs_unattached policy?

@athiruma
Copy link
Collaborator Author

@athiruma, What the purpose to add ebs_unattached policy?

I missed the tagging of the ebs_unattahced volumes. So I added it here.

ebattat
ebattat approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 23618de into redhat-performance:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat approved these changes

Assignees

@athiruma athiruma

Labels
bug Something isn't working ok-to-test PR ok to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat