Added the active regions to the policies #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebattat
reviewed
Nov 15, 2023
| @@ -33,7 +33,7 @@ def run(self): | |||
| for policy_dict in policy_result: | |||
| policy_dict['region_name'] = self._region | |||
| policy_dict['account'] = self._account | |||
| self._es_operations.upload_to_elasticsearch(data=policy_dict, index=self._es_index) | |||
| self._es_operations.upload_to_elasticsearch(data=policy_dict.copy(), index=self._es_index) | |||
There was a problem hiding this comment.
What the purpose of copy ?
There was a problem hiding this comment.
I do not want to pass ref value, I need to send the values directly.
There was a problem hiding this comment.
Did you test it, is it work ?
There was a problem hiding this comment.
Are u sure its documentation issue ?
There was a problem hiding this comment.
Added bug label too
ebattat
approved these changes
Nov 15, 2023
| @@ -33,7 +33,7 @@ def run(self): | |||
| for policy_dict in policy_result: | |||
| policy_dict['region_name'] = self._region | |||
| policy_dict['account'] = self._account | |||
| self._es_operations.upload_to_elasticsearch(data=policy_dict, index=self._es_index) | |||
| self._es_operations.upload_to_elasticsearch(data=policy_dict.copy(), index=self._es_index) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Added the active regions to the policies.
For security reasons, all pull requests need to be approved first before running any automated CI