Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the bucket_path warning #702

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Added the bucket_path warning #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions cloud_governance/policy/common_policies/send_aggregated_alerts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ def __get_kerberos_users_for_iam_users(self):
"""
responses = {}
users = self.__environment_variables.get('KERBEROS_USERS')
for iam_user, kerberos_user in users.items():
responses[iam_user.lower()] = kerberos_user.lower()
if users:
for iam_user, kerberos_user in users.items():
responses[iam_user.lower()] = kerberos_user.lower()
return responses

def __get_users_agg_result(self, policy_result: list, agg_users_result: dict, policy_name: str, region: str):
Expand Down Expand Up @@ -81,11 +82,15 @@ def __get_policy_data_in_bucket(self, region: str, policy: str):
try:
policy_save_path = f'{self.__bucket_key}/{region}/{policy}'
bucket_path_file = self.__s3_operations.get_last_objects(bucket=self.__bucket_name, key_prefix=f'{policy_save_path}/{self.TODAY_DATE}')
policy_s3_response = self.__s3_operations.get_last_s3_policy_content(s3_file_path=bucket_path_file, file_name=self.FILE_NAME)
return json.loads(policy_s3_response) if policy_s3_response else []
if bucket_path_file:
policy_s3_response = self.__s3_operations.get_last_s3_policy_content(s3_file_path=bucket_path_file, file_name=self.FILE_NAME)
return json.loads(policy_s3_response) if policy_s3_response else []
else:
logger.warn(f"No file_path: {policy_save_path}/{self.TODAY_DATE} exists in s3 bucket")
except ClientError as err:
logger.info(err)
return []
return []

@logger_time_stamp
def __get_policy_users_list(self):
Expand Down
Loading