Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decalred the vars to env file #705

Merged
merged 1 commit into from
Dec 20, 2023
Merged

decalred the vars to env file #705

merged 1 commit into from
Dec 20, 2023

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Declared the AWS access keys as env var in the file

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added bug Something isn't working ok-to-test PR ok to test labels Dec 20, 2023
@athiruma athiruma requested a review from ebattat December 20, 2023 05:38
@athiruma athiruma self-assigned this Dec 20, 2023
ebattat
ebattat approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 33ccd0c into redhat-performance:main Dec 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat approved these changes

Assignees

@athiruma athiruma

Labels
bug Something isn't working ok-to-test PR ok to test
Projects
Cloud-Governance project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat