Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the azure ec2_run policy #711

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Added the azure ec2_run policy #711

merged 1 commit into from
Jan 2, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Dec 26, 2023 •
edited
Loading

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

In Azure, an instance is called a VM
  1. Adding the azure VM run
  2. Added the unit test cases for the vm_run policy
  3. Added functionalities
    1. Created the main_operations: All policy runner calls will be taken from this file.
    2. Created a separate class for Azure/ was the main policy runners
  4. The policy implementation UM diagram is attached below.
  5. Any policy implementation needs to follow this approach.

Updated UML dia
Policy Implementation-Policy Implementation (1)

Grafana Panel with combined of instance_run and ec2_run
Screenshot 2023-12-28 at 11 38 17 AM

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added enhancement New feature or request ok-to-test PR ok to test labels Dec 26, 2023
@athiruma athiruma requested a review from ebattat December 26, 2023 12:12
@athiruma athiruma self-assigned this Dec 26, 2023
@athiruma athiruma force-pushed the add_azure_vm_run branch 17 times, most recently from a18ea04 to 25a08e6 Compare December 28, 2023 07:08
ebattat
ebattat reviewed Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that data distribute properly into Elastic/Grafana ?

cloud_governance/common/helpers/azure/azure_cleanup_operations.py Outdated Show resolved Hide resolved
cloud_governance/common/helpers/cleanup_operations.py
@@ -14,13 +14,27 @@ class AbstractCleanUpOperations(ABC):

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to change class name to PolicyOperations ?

cloud_governance/common/helpers/aws/aws_cleanup_operations.py Show resolved Hide resolved
cloud_governance/common/helpers/azure/azure_cleanup_operations.py Outdated Show resolved Hide resolved
docs/source/index.md Show resolved Hide resolved
@athiruma
Copy link
Collaborator Author

Did you check that data distribute properly into Elastic/Grafana ?

Yes, see the grafana snap in the description.

@athiruma
Copy link
Collaborator Author

athiruma commented Dec 28, 2023 •
edited
Loading

Policy Implementation-Policy Implementation (1)
@ebattat Updated the diagram

@athiruma
Copy link
Collaborator Author

athiruma commented Jan 2, 2024

Old versions: [ Keeping here for the version tracking. ]
Policy Implementation (1)
Policy Implementation-Policy Implementation

@ebattat ebattat merged commit 979d89d into redhat-performance:main Jan 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat left review comments

Assignees

@athiruma athiruma

Labels
enhancement New feature or request ok-to-test PR ok to test
Projects
Cloud-Governance project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat