Added the azure volume unattached #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
force-pushed
the
azure_avialable_volumes
branch
3 times, most recently
from
bd7afe8 to
44abd64
Compare
athiruma
force-pushed
the
azure_avialable_volumes
branch
from
44abd64 to
f902739
Compare
ebattat
reviewed
Jan 5, 2024
| @@ -38,7 +38,7 @@ def run(self): | |||
| policy_runner = self.get_policy_runner() | |||
| for policy_type, policies in policies_list.items(): | |||
| # @Todo support for all the aws policies, currently supports ec2_run as urgent requirement | |||
| if self._policy in policies and self._policy in "instance_run": | |||
| if self._policy in policies and self._policy in ["instance_run", "unattached_volume"]: | |||
There was a problem hiding this comment.
Is it going to change inthe future, if yes add todo comment?
There was a problem hiding this comment.
Already have the comment above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Added the azure volumes_unattached policy.
For security reasons, all pull requests need to be approved first before running any automated CI