-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure: Added the ip_unattacheed policy #728
Conversation
63490e1
to
7052d10
Compare
7052d10
to
64a4b80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@athiruma, did you verify that its not related to any live cluster before deletion ?
cluster_tag = self._get_cluster_tag(tags=address.get('Tags')) | ||
if cluster_tag not in active_cluster_ids: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check cluster tag not in active clusters
cluster_tag = self._get_cluster_tag(tags=tags) | ||
if cluster_tag not in active_cluster_ids: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we add the same for AWS policy ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
yes, before doing operation checking the cluster tag in active clusters |
@athiruma, I will approve it but please add todo for adding integration tests in the future |
Open Issue for adding the integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Type of change
Note: Fill x in []
Description
For security reasons, all pull requests need to be approved first before running any automated CI