Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: Added the ip_unattacheed policy #728

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Added the azure ip_unattached policy.
  2. Changed the AWS ip_unattched to the new approach.
  3. Added the unit tests for both aws and azure

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added enhancement New feature or request ok-to-test PR ok to test labels Feb 16, 2024
@athiruma athiruma requested a review from ebattat February 16, 2024 11:10
@athiruma athiruma self-assigned this Feb 16, 2024
@athiruma athiruma force-pushed the azure_ip_unattached branch 9 times, most recently from 63490e1 to 7052d10 Compare February 16, 2024 19:54
@athiruma athiruma force-pushed the azure_ip_unattached branch from 7052d10 to 64a4b80 Compare February 16, 2024 20:02
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma, did you verify that its not related to any live cluster before deletion ?

Comment on lines +29 to +30
cluster_tag = self._get_cluster_tag(tags=address.get('Tags'))
if cluster_tag not in active_cluster_ids:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check cluster tag not in active clusters

Comment on lines +47 to +48
cluster_tag = self._get_cluster_tag(tags=tags)
if cluster_tag not in active_cluster_ids:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we add the same for AWS policy ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@athiruma
Copy link
Collaborator Author

@athiruma, did you verify that its not related to any live cluster before deletion ?

yes, before doing operation checking the cluster tag in active clusters

@ebattat
Copy link
Collaborator

ebattat commented Feb 19, 2024

@athiruma, I will approve it but please add todo for adding integration tests in the future

@athiruma
Copy link
Collaborator Author

Open Issue for adding the integration tests.

Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 6a5f447 into redhat-performance:main Feb 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants