Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordered policies and enabled the all Policies in PSAP #733

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Feb 21, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Enabled the policies in PSAP
  2. Re-arranged the policies to run
  3. Policies running dry_run=no: ["ec2_idle", "ec2_stop", "unattached_volume", "ip_unattached", "zombie_snapshots", "unused_nat_gateway", "s3_inactive", "empty_roles", "zombie_cluster_resource"]

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added documentation Improvements or additions to documentation ok-to-test PR ok to test labels Feb 21, 2024
@athiruma athiruma requested a review from ebattat February 21, 2024 07:38
@athiruma athiruma self-assigned this Feb 21, 2024
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to review it together, a lot of deletion done by you

agent {
docker {
label 'cloud-governance-worker'
label 'haim-cloud-governance-worker'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why haim ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad. Fixed it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets review it together before merging

Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat changed the title Enabled the CloudGovernance Policies in PSAP Reordered policies and enabled the all Policies in PSAP Feb 22, 2024
@ebattat ebattat merged commit ac08b64 into redhat-performance:main Feb 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants