Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the azure unused_nat_gateway policy #745

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Azure Policy: UnUsedNatGateway

  1. Added the unused nat_gateway policy
  2. Follow
    1. Check for the last 7 days' metrics
    2. If less than the average 5 BytesCount for the last 7 days set it as unused
  3. Change the AWS UnUsedNatGateway to a new way
  4. Added the unit test cases.

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added enhancement New feature or request ok-to-test PR ok to test labels Mar 25, 2024
@athiruma athiruma requested a review from ebattat March 25, 2024 12:25
@athiruma athiruma self-assigned this Mar 25, 2024
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM - lets review it together

@athiruma athiruma force-pushed the azure_nat_gateway branch from afdf497 to 4e6c1df Compare April 1, 2024 05:01
@ebattat
Copy link
Collaborator

ebattat commented Apr 1, 2024

@athiruma pls fix conflict

@athiruma athiruma force-pushed the azure_nat_gateway branch from 4e6c1df to a44477e Compare April 1, 2024 07:33
@athiruma athiruma force-pushed the azure_nat_gateway branch from a44477e to 1f114e1 Compare April 1, 2024 12:36
class UnUsedNatGateway(AWSPolicyOperations):
"""
This class sends an alert mail for zombie Nat gateways ( based on vpc routes )
to the user after 4 days and delete after 7 days.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SNATConnectionCount
I think that the comment should be here

@ebattat ebattat merged commit 9b13bc0 into redhat-performance:main Apr 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants