Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the ebs unit price #756

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Added the ebs unit price #756

merged 1 commit into from
Apr 18, 2024

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added documentation Improvements or additions to documentation ok-to-test PR ok to test labels Apr 18, 2024
@athiruma athiruma requested a review from ebattat April 18, 2024 06:26
@athiruma athiruma self-assigned this Apr 18, 2024
ebattat
ebattat reviewed Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its only how much we pay on the storage.
In io2 we pay also on the data transfer.
Is there a way to add it also ?

@athiruma
Copy link
Collaborator Author

I think its only how much we pay on the storage. In io2 we pay also on the data transfer. Is there a way to add it also ?

t is difficult to calculate the data transfer costs. We need to gather data transfer metrics from the beginning of the volume. Let's add the unit price of the volume.

@ebattat
Copy link
Collaborator

ebattat commented Apr 18, 2024

Yes as I guess

ebattat
ebattat approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 3c8d0a3 into redhat-performance:main Apr 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat approved these changes

Assignees

@athiruma athiruma

Labels
documentation Improvements or additions to documentation ok-to-test PR ok to test
Projects
Cloud-Governance project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat