Policy: Added the database_idle policy #780
Conversation
| from cloud_governance.common.logger.init_logger import logger | ||
|
|
||
|
|
||
| class RdsOperations: |
There was a problem hiding this comment.
RDS - should be upper case
| @@ -26,3 +31,21 @@ def get_tag_value_from_tags(tags: list, tag_name: str, cast_type: str = 'str', | |||
| return str(tag.get('Value').strip()) | |||
| return tag.get('Value').strip() | |||
| return default_value | |||
|
|
|||
|
|
|||
| def boto3_client(client: str, region_name: str, **kwargs): | |||
There was a problem hiding this comment.
I dont know if it good idea to create method only for aws boto3 client initialization
There was a problem hiding this comment.
Instead of calling the boto3 method every time, I thought to create one method to return the client.
There was a problem hiding this comment.
It slight confused for code reviewer to see that calling the client with boto3_client instead of boto3.client
There was a problem hiding this comment.
I intend to make better exception handling of client errors.
May we can change the method name?
There was a problem hiding this comment.
Do you think create_boto3_client is better ?
There was a problem hiding this comment.
get_boto3_client??
There was a problem hiding this comment.
Did u replace all the place that using boto3 client ?
There was a problem hiding this comment.
No, I will open the new PR.
| :rtype: | ||
| """ | ||
| total_connections = self.__get_db_connection_status(resource_id) | ||
| return total_connections <= 0 |
There was a problem hiding this comment.
Why total_connections <= 0
I think it should be: return total_connections
There was a problem hiding this comment.
Method name: is_database_idle()
There was a problem hiding this comment.
In idle case it should be <= 0
athiruma
force-pushed
the
database_idle
branch
2 times, most recently
from
866e890 to
8a30af9
Compare
Type of change
Note: Fill x in []
Description
Policy: database_idle
Description: Check for last 14days database connections in cloudwatch.
Note: CloudWatch retains metrics for only 14 days.
For security reasons, all pull requests need to be approved first before running any automated CI