Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the setuptools in pypi_validate #796

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Jun 5, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Add the setuptools in pypi_validate

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added bug Something isn't working ok-to-test PR ok to test labels Jun 5, 2024
@athiruma athiruma requested a review from ebattat June 5, 2024 11:50
@athiruma athiruma self-assigned this Jun 5, 2024
@@ -274,6 +274,7 @@ jobs:
# Verfiy and wait till latest cloud-governance version will be updated in Pypi (timeout 900 seconds)
timeout=900
sleep_time=30
pip install setuptools
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls write it in 1 line instead of 2
pip --no-cache-dir install setuptools cloud-governance --upgrade

@ebattat
Copy link
Collaborator

ebattat commented Jun 5, 2024

@athiruma , Pls also add it here
pip install setuptools bumpversion

Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 174662c into redhat-performance:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants