Fix the elasticsearch, numpy versions #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebattat
reviewed
Jun 19, 2024
requirements.txt
Outdated
| @@ -19,8 +19,9 @@ google-cloud-bigquery==3.5.0 | |||
| google-cloud-billing==1.9.1 | |||
| ibm_platform_services==0.27.0 | |||
| myst-parser==1.0.0 | |||
| numpy==1.26.4 | |||
There was a problem hiding this comment.
@athiruma, failed use 1.24.4 instead
There was a problem hiding this comment.
pls add comment with opensearch 1.2.4 for numpy/pandas/elasticsearch
athiruma
force-pushed
the
fix_elastic_search_version
branch
3 times, most recently
from
ab733a5 to
a4b0281
Compare
athiruma
force-pushed
the
fix_elastic_search_version
branch
from
a4b0281 to
0ebce4c
Compare
athiruma
changed the title
athiruma
force-pushed
the
fix_elastic_search_version
branch
2 times, most recently
from
2f1e3a1 to
e0f75c7
Compare
athiruma
force-pushed
the
fix_elastic_search_version
branch
from
e0f75c7 to
88e28f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
elastic search client version must satisfy the host version.
python=3.8 :
numpy must be at 1.24.4
So added numpy<=1.26.4 to support for all versions
Solved the following issue:
AttributeError:np.float_was removed in the NumPy 2.0 release. Usenp.float64instead.For security reasons, all pull requests need to be approved first before running any automated CI