Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the cluster fields #818

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Aug 9, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Add the cluster fields:

  • CreationDate
  • StoppedDate
  • ClusterState
  • ClusterName

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added the documentation Improvements or additions to documentation label Aug 9, 2024
@athiruma athiruma requested a review from ebattat August 9, 2024 07:28
@athiruma athiruma self-assigned this Aug 9, 2024
@athiruma athiruma added the ok-to-test PR ok to test label Aug 9, 2024
cluster_data[cluster_tag]['Instances'].append(instance_data)
cluster_data[cluster_tag]['InstanceCount'] = len(cluster_data[cluster_tag]['Instances'])
cluster_data[cluster_tag]['Stopped'] = int(cluster_data[cluster_tag]['Stopped']) + stopped_instances
cluster_data[cluster_tag]['Running'] = int(cluster_data[cluster_tag]['Running']) + running_instances
else:
cluster_data[cluster_tag] = {
'ClusterName': cluster_tag.split('/')[-1].upper(),
'ClusterName2': cluster_tag.split('/')[-1].lower(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma, do u think we need the lower also ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it on safe side.

@athiruma
Copy link
Collaborator Author

@ebattat ??

Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit a3b70b0 into redhat-performance:main Aug 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ok-to-test PR ok to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants