Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: monitor long running resources #826

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Sep 1, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Azure CloudSesei - report the long-running resources in Azure.

  • Currently sending slack notifications.

https://issues.redhat.com/browse/CLGOVNR-21

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added enhancement New feature or request ok-to-test PR ok to test labels Sep 1, 2024
@athiruma athiruma self-assigned this Sep 1, 2024
@athiruma athiruma force-pushed the azure_resource_monitor branch from d5b605e to b88dd44 Compare September 1, 2024 06:06
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add cost for each instance ?

@athiruma
Copy link
Collaborator Author

athiruma commented Sep 1, 2024

Did you add cost for each instance ?

I will open a new PR to add cost reports. They requested that cost reports be included in the mail/Slack.

@@ -217,3 +217,4 @@ empty_test_environment_variables.py
/cloud_governance/main/.test_env
/cloud_governance/policy/send_mail.py
cloudsensei/.env.txt
.vscode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though harmless - do we need this :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to store vscode files in GitHub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Member

@krishvoor krishvoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma
Copy link
Collaborator Author

athiruma commented Sep 2, 2024

Can you not reuse this https://github.com/redhat-performance/cloud-governance/blob/main/cloudsensei/slack_operations.py -?

We need to create a bundle so that all files must be in one place.

@athiruma
Copy link
Collaborator Author

athiruma commented Sep 2, 2024

Can you not reuse this https://github.com/redhat-performance/cloud-governance/blob/main/cloudsensei/slack_operations.py -?

We need to create a bundle so that all files must be in one place.

I'll create a plan to make it easier. May be in new pr.

@krishvoor
Copy link
Member

Can you not reuse this https://github.com/redhat-performance/cloud-governance/blob/main/cloudsensei/slack_operations.py -?

We need to create a bundle so that all files must be in one place.

I'll create a plan to make it easier. May be in new pr.

All right, this PR is /lgtm. Please merge it!

@ebattat ebattat merged commit 7a9d70a into redhat-performance:main Sep 2, 2024
18 checks passed
Copy link
Member

@krishvoor krishvoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

3 participants