-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure: monitor long running resources #826
Azure: monitor long running resources #826
Conversation
d5b605e
to
b88dd44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you add cost for each instance ?
I will open a new PR to add cost reports. They requested that cost reports be included in the mail/Slack. |
@@ -217,3 +217,4 @@ empty_test_environment_variables.py | |||
/cloud_governance/main/.test_env | |||
/cloud_governance/policy/send_mail.py | |||
cloudsensei/.env.txt | |||
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though harmless - do we need this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to store vscode files in GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you not reuse this https://github.com/redhat-performance/cloud-governance/blob/main/cloudsensei/slack_operations.py -?
We need to create a bundle so that all files must be in one place. |
I'll create a plan to make it easier. May be in new pr. |
All right, this PR is /lgtm. Please merge it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Type of change
Note: Fill x in []
Description
Azure CloudSesei - report the long-running resources in Azure.
https://issues.redhat.com/browse/CLGOVNR-21
For security reasons, all pull requests need to be approved first before running any automated CI