Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the unit price to policies #830

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Sep 5, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Added the unit price to missing policies.

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added documentation Improvements or additions to documentation ok-to-test PR ok to test labels Sep 5, 2024
@athiruma athiruma requested a review from ebattat September 5, 2024 08:34
@athiruma athiruma self-assigned this Sep 5, 2024
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan also to add volume price ?

@ebattat
Copy link
Collaborator

ebattat commented Sep 5, 2024

Can you please add integration test, to verify that we get unit cost properly ?

@athiruma
Copy link
Collaborator Author

athiruma commented Sep 5, 2024

Do you plan also to add volume price ?

I added it already to unattached_volume.

@athiruma
Copy link
Collaborator Author

athiruma commented Sep 5, 2024

Can you please add integration test, to verify that we get unit cost properly ?

yup, okay.

Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit b708db7 into redhat-performance:main Sep 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants