Tenant QE account #840
Merged
Tenant QE account #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
force-pushed
the
add_eyal_accounts
branch
from
69b7a1a to
c98e8f3
Compare
athiruma
force-pushed
the
add_eyal_accounts
branch
4 times, most recently
from
80c8c71 to
3bf8385
Compare
|
/review @ebattat |
ebattat
reviewed
Sep 22, 2024
| stage('Initial Cleanup') { | ||
| steps { | ||
| sh '''if [[ "$(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null)" != "" ]]; then podman rmi -f $(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null); fi''' | ||
| } |
There was a problem hiding this comment.
Why are we still using quay.io/ebattat/cloud-governance ?
| } | ||
| stage('Initial Cleanup') { | ||
| steps { | ||
| sh '''if [[ "$(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null)" != "" ]]; then podman rmi -f $(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null); fi''' |
There was a problem hiding this comment.
Why are we still using quay.io/ebattat/cloud-governance ?
| stage('Finalize Cleanup') { | ||
| steps { | ||
| sh '''if [[ "$(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null)" != "" ]]; then podman rmi -f $(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null); fi''' | ||
| deleteDir() |
There was a problem hiding this comment.
Why are we still using quay.io/ebattat/cloud-governance ?
| stage('Finalize Cleanup') { | ||
| steps { | ||
| sh '''if [[ "$(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null)" != "" ]]; then podman rmi -f $(podman images -q quay.io/ebattat/cloud-governance 2> /dev/null); fi''' | ||
| deleteDir() |
There was a problem hiding this comment.
Why are we still using quay.io/ebattat/cloud-governance ?
There was a problem hiding this comment.
I opened this PR, before we merging the change
ebattat
requested changes
Sep 22, 2024
athiruma
force-pushed
the
add_eyal_accounts
branch
from
3bf8385 to
ed60e59
Compare
athiruma
force-pushed
the
add_eyal_accounts
branch
from
ed60e59 to
94597fb
Compare
Yup done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Add tenant:
Used the cloud-governance es_host and es_port.
For security reasons, all pull requests need to be approved first before running any automated CI