Fix public image build #844
Conversation
There was a problem hiding this comment.
Pls remove the extra enter:
cloud-governance/.github/workflows/Build.yml
Lines 298 to 299 in 67e0424
| @@ -313,8 +313,6 @@ jobs: | |||
| python-version: ${{ matrix.python-version }} | |||
| - name: ⌛ Upload to 🐋 quay.io | |||
| run: | | |||
| pip install setuptools | |||
| version=$(python3 setup.py --version) | |||
There was a problem hiding this comment.
Why did u delete the version ?
There was a problem hiding this comment.
we always use the latest version, so there is no need for it.
There was a problem hiding this comment.
Remove also build and push also
Also delete extra space
There was a problem hiding this comment.
We are publishing to the public quay so build and push must be there.
I don't find extra spaces.
athiruma
force-pushed
the
fix_public_build
branch
from
67e0424 to
b29ff3f
Compare
|
So let remove also: cloud-governance/.github/workflows/Build.yml Line 342 in 67e0424 cloud-governance/.github/workflows/Build.yml Line 339 in 67e0424 |
here we should do, as because for the public image no need to pass the version, just latest is enough. |
| @@ -313,8 +313,6 @@ jobs: | |||
| python-version: ${{ matrix.python-version }} | |||
| - name: ⌛ Upload to 🐋 quay.io | |||
| run: | | |||
| pip install setuptools | |||
| version=$(python3 setup.py --version) | |||
There was a problem hiding this comment.
Remove also build and push also
Also delete extra space
right, but this is a public quay. we want to maintain only latest version. |
Type of change
Note: Fill x in []
Description
Public Image cloud-governance pypi package is 1.1.306, however it should be 1.1.307.
For security reasons, all pull requests need to be approved first before running any automated CI