Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ec2 delete methods #849

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Oct 9, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Added the ec2 delete methods.

This helps to delete the zombie cluster/ zombie resources directly calling from ec2_operations

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added the enhancement New feature or request label Oct 9, 2024
@athiruma athiruma requested a review from ebattat October 9, 2024 08:13
@athiruma athiruma self-assigned this Oct 9, 2024
@athiruma athiruma changed the base branch from main to zombie_cluster October 9, 2024 08:13
@athiruma athiruma added the ok-to-test PR ok to test label Oct 9, 2024
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach.
Could you please add to the documentation the correct process for deleting a resources?

@athiruma
Copy link
Collaborator Author

athiruma commented Oct 9, 2024

Nice approach. Could you please add to the documentation the correct process for deleting a resources?

Thanks. This is just the ec2 method, I'll open a new PR of zombie_cluster_resource refractor. You can find the description of how to delete the resource.

Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit caa8195 into redhat-performance:zombie_cluster Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants