Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the IBM VPC tagging #861

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Added the tag_resource policy to tag IBM resources:
List of resources tagging in IBM:

  • "virtual_servers",
  • "volumes",
  • "floating_ips",
  • "vpcs",
  • "virtual_network_interfaces",
  • "security_groups",
  • "public_gateways",
  • "vpc_endpoint_gateways",
  • "load_balancers",
  • "schematics_workspaces"

ENV's to support:

  • IBM_CUSTOM_TAGS_LIST : "cost-center: 675, key:value" # format
  • RESOURCE_TO_TAG: "virtual_servers" # tag specific resource

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added enhancement New feature or request ok-to-test PR ok to test labels Oct 30, 2024
@athiruma athiruma requested a review from ebattat October 30, 2024 05:05
@athiruma athiruma self-assigned this Oct 30, 2024
@ebattat
Copy link
Collaborator

ebattat commented Oct 30, 2024

Great job,
@athiruma, is it include: VCF as a Service - Cloud Director Site ?

@athiruma
Copy link
Collaborator Author

Great job, @athiruma, is it include: VCF as a Service - Cloud Director Site ?

I think, schematics_workspaces is related to VCF. Not exactly but it will give us an understand which resources are missing and will add it in next phase.

@athiruma athiruma added ok-to-test PR ok to test and removed ok-to-test PR ok to test labels Oct 30, 2024
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat
Copy link
Collaborator

ebattat commented Nov 3, 2024

@athiruma, can we merge it ?

@athiruma
Copy link
Collaborator Author

athiruma commented Nov 4, 2024

@athiruma, can we merge it ?

Yes

@ebattat ebattat merged commit b27c35b into redhat-performance:main Nov 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants