Removed the env variable in scripts #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebattat
reviewed
Nov 5, 2024
| @@ -39,6 +39,9 @@ pipeline { | |||
| contact4 = "[email protected]" | |||
| // Find the all available policies: https://github.com/redhat-performance/cloud-governance/tree/main/cloud_governance/policy | |||
| // By default, all policies are running in dry_run="yes" mode and the whole list can be found in run_policies.py | |||
| // POLICIES_IN_ACTION: Policies that run in the dry_run="no" mode | |||
| POLICIES_IN_ACTION = '["unattached_volume", "ip_unattached", "zombie_snapshots", "unused_nat_gateway", "s3_inactive", "empty_roles"]' | |||
There was a problem hiding this comment.
Why did u delete "zombie_cluster_resource" ?
There was a problem hiding this comment.
I want to simulate the old scenario. After adding the zombie_cluster_resources policy it behaving wiered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Unusual activity, mails are sent multiple times. Removed the env in scripts and verified it's working.
For security reasons, all pull requests need to be approved first before running any automated CI