Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip gcp tests #882

Merged
merged 1 commit into from
Dec 9, 2024
Merged

skip gcp tests #882

merged 1 commit into from
Dec 9, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Dec 9, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added bug Something isn't working ok-to-test PR ok to test labels Dec 9, 2024
@athiruma athiruma requested a review from ebattat December 9, 2024 06:17
@athiruma athiruma self-assigned this Dec 9, 2024
from cloud_governance.common.clouds.gcp.google_account import GoogleAccount
from cloud_governance.main.environment_variables import environment_variables


@pytest.mark.skip(reason="Data is not being exported to the database")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comment with Ticket id ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma, I dont see the comment in the code, where u add it ?

@athiruma
Copy link
Collaborator Author

athiruma commented Dec 9, 2024

Case 55659104: The database table is not updated

Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 8b46e28 into redhat-performance:main Dec 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants