Check the previous cost before sending an alert #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
force-pushed
the
cro_pre_check_budget
branch
from
03bffb6 to
27dd648
Compare
ebattat
reviewed
Dec 9, 2024
| :return: | ||
| """ | ||
| current_date = datetime.now(timezone.utc).date() | ||
| start_date = current_date - timedelta(days=10) | ||
| start_date = current_date - timedelta(days=15) |
There was a problem hiding this comment.
Why we need to increase the days to 15 ?
There was a problem hiding this comment.
To reduce the mailing aggressiveness, send mail every 2 weeks.
athiruma
force-pushed
the
cro_pre_check_budget
branch
from
27dd648 to
5d62cbe
Compare
ebattat
approved these changes
Dec 9, 2024
| :return: | ||
| """ | ||
| current_date = datetime.now(timezone.utc).date() | ||
| start_date = current_date - timedelta(days=10) | ||
| start_date = current_date - timedelta(days=15) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Check the remaining cost in the last email before sending the budget email. Reduced the aggressiveness from 10 -> 15 days.
For security reasons, all pull requests need to be approved first before running any automated CI