bootloader: Simplify tuning of rpm-ostree kargs #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bootloader plugin claims that it does not mess with existing kernel parameters; make sure we adhere to that also for rpm-ostree systems: 1. Only append a new karg if the same key=value pair does not already appear in kernel parameters. If we would duplicate it, it would not be possible to determine which one to delete when unapplying the profile. 2. Do not delete existing key=value pairs when the profile adds a karg with another value for the key. A single key can appear multiple times in the kernel parameter list with different values. Also make sure new kargs are added exactly in the order in which they appear in the profile. This is especially important for kargs related to hugepages. Resolves: RHEL-45836
zacikpa
force-pushed
the
rpm-ostree-fix
branch
from
d6801e7 to
f9f5e9e
Compare
There is an older grub convention that TuneD cannot change/delete any karg it didn't add itself, so I think this restriction is OK. One question, what happen if there is running deployment or the |
I will re-check that, can't remember if I tested such cases or not, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify the tuning of kernel parameters in rpm-ostree systems, which has some major flaws:
The new implementation is much simpler, but it also restricts the user more, since it disallows replacing existing kernel parameters.
Setting to WIP, since I'm still doing testing on Fedora CoreOS virtual machines.