Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue tagging to work without helper scripts #172

Merged
merged 17 commits into from
Feb 25, 2025
Merged

Conversation

kdvalin
Copy link
Member

@kdvalin kdvalin commented Feb 12, 2025

Description

This updates the issue tagging pipeline to work without relying on helper scripts. This allows for a simple import into other repositories to use.

Before/After Comparison

Before

Importing the workflow into another repo would cause it to error out since the helper scripts are not present.

After

Importing the workflow into another repository works as expected

Clerical Stuff

Issue #167

Relates to JIRA: RPOPC-327

@kdvalin kdvalin requested a review from a team February 12, 2025 19:46
Copy link

This relates to RPOPC-327

@kdvalin kdvalin requested review from a team and removed request for a team February 12, 2025 19:49
@kdvalin kdvalin requested review from dvalinrh and removed request for a team February 12, 2025 19:51
@kdvalin kdvalin requested review from dvalinrh and removed request for dvalinrh February 12, 2025 20:28
@kdvalin kdvalin requested review from dvalinrh and removed request for dvalinrh February 12, 2025 20:30
@kdvalin kdvalin requested review from dvalinrh and removed request for dvalinrh February 12, 2025 20:33
@kdvalin kdvalin requested review from dvalinrh and removed request for dvalinrh February 12, 2025 20:35
@kdvalin kdvalin requested review from dvalinrh and removed request for dvalinrh February 12, 2025 20:36
@kdvalin kdvalin requested review from dvalinrh and removed request for dvalinrh February 12, 2025 20:38
@kdvalin kdvalin requested a review from a team February 12, 2025 20:40
Copy link
Contributor

@frival frival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you left in a file by accident?

tmp.json Outdated
@@ -0,0 +1,44 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this included by accident? If not it could really use a better file name than "tmp.json" unless the workflow demands it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, had that as a testing file and forgot to remove it.

@kdvalin kdvalin requested a review from frival February 13, 2025 14:11
frival
frival previously approved these changes Feb 13, 2025
Copy link
Contributor

@frival frival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please file an issue to document the jira-issues-tagging container for other developers & maintainers.

dvalinrh
dvalinrh previously approved these changes Feb 18, 2025
Copy link
Contributor

@dvalinrh dvalinrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdvalin kdvalin requested a review from a team February 18, 2025 13:12
Copy link
Contributor

@dvalinrh dvalinrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvalinrh dvalinrh added the group_review_lgtm Indicates approval after a group review meeting label Feb 25, 2025
@kdvalin kdvalin merged commit 2315866 into main Feb 25, 2025
3 checks passed
@kdvalin kdvalin deleted the ci/standalone branch February 25, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group_review_lgtm Indicates approval after a group review meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants