Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RHEL-55734) remove /run/credentials/ mount for oneshot services #33

Merged
merged 2 commits into from
Aug 22, 2024
Merged

(RHEL-55734) remove /run/credentials/ mount for oneshot services #33

merged 2 commits into from
Aug 22, 2024

Conversation

lnykryn
Copy link
Member

@lnykryn lnykryn commented Aug 22, 2024 •
edited by github-actions bot
Loading

No description provided.

@YHNdnzj @lnykryn
core/unit: add one assertion for u->manager
32d02c9 
(cherry picked from commit 8b17371b6185c9829bb21a813aadb2225ccfc4de)

Resolves: RHEL-55734
@YHNdnzj @lnykryn
core/service: destroy runtime data when Type=oneshot services exit
a9ac0af 
Currently, we have a bunch of Type=oneshot + RemainAfterExit=yes
services that make use of credentials. When those exits, the cred mounts
remain established, which is pointless and quite annoying. Let's
instead destroy the runtime data on SERVICE_EXITED, if no process
will be spawned for the unit again.

(cherry picked from commit c26948c6dae1d2ca13499b36f193b13a0760834c)

Resolves: RHEL-55734
@github-actions github-actions bot changed the title Rhel 55734 (RHEL-55734) Rhel 55734 Aug 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

Commit validation

Tracker - RHEL-55734

The following commits meet all requirements

commit upstream
32d02c9 - core/unit: add one assertion for u->manager systemd/systemd@8b17371
a9ac0af - core/service: destroy runtime data when Type=oneshot services exit systemd/systemd@c26948c

Tracker validation

Success

🟢 Tracker RHEL-55734 has set desired product: rhel-10.0.beta
🟢 Tracker RHEL-55734 has set desired component: systemd
🟢 Tracker RHEL-55734 has been approved

Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

@lnykryn lnykryn changed the title (RHEL-55734) Rhel 55734 (RHEL-55734) remove /run/credentials/ mount for oneshot services Aug 22, 2024
msekletar
msekletar approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot merged commit 45d3266 into redhat-plumbers:main Aug 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msekletar msekletar msekletar approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lnykryn @msekletar @jamacku @YHNdnzj